This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED] [PATCH] posix: Fix posix_spawn invalid memory access
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 21 Mar 2016 14:54:13 +0100
- Subject: Re: [COMMITTED] [PATCH] posix: Fix posix_spawn invalid memory access
- Authentication-results: sourceware.org; auth=none
- References: <1458508785-31315-1-git-send-email-adhemerval dot zanella at linaro dot com>
* Adhemerval Zanella:
> - if (!ec && new_pid)
> + if (!ec && pid)
I think the general convention is not to perform implicit NULL checks,
so it should be âpid != NULLâ.