This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Delete dead code? [BZ 19653]


Greetings,

Quoting from https://sourceware.org/bugzilla/show_bug.cgi?id=19653
"if this is re-enabled in the future, it could segmentation fault
without the check for NULL from malloc()."

AFAICT, the code comes from:

commit 49633efbcc056cc97928b22ff274b5774839bfae
Author: Roland McGrath <roland@gnu.org>
Date:   Wed Jul 26 00:13:55 1995 +0000

    New file, based on NET2 code but with DES code removed.

and has been ifdef'd out since then.

Should we just delete the '#if 0'd blocks?


2016-03-20  Paul Pluzhnikov  <ppluzhnikov@google.com>

        [BZ 19653]
        * inet/if_index.c (__protocol_available): Delete.
        * inet/ruserpass.c (ruserpass): Delete #if 0'd code.


Thanks,
-- 
Paul Pluzhnikov

Attachment: glibc-bz19653-20160320.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]