This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Joseph Myers <joseph at codesourcery dot com>, Siddhesh Poyarekar <sid at reserved-bit dot com>, libc-alpha at sourceware dot org, Tom Tromey <tom at tromey dot com>, Torvald Riegel <triegel at redhat dot com>, Pedro Alves <palves at redhat dot com>, vapier at gentoo dot org, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Fri, 18 Mar 2016 12:53:47 -0300
- Subject: Re: [PING 2][PATCH v3] Add pretty printers for the NPTL lock types
- Authentication-results: sourceware.org; auth=none
- References: <1447768994-5368-1-git-send-email-martin dot galvan at tallertechnologies dot com> <20160209155450 dot GE1904 at devel dot intra dot reserved-bit dot com> <CAOKbPbYPtn5mMpwGGD-HccXnhNz+eymiJ7Xwe_4WOnesYkw5=A at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602091743430 dot 29757 at digraph dot polyomino dot org dot uk> <CAOKbPba5MGw8XCXRSvapfADD1v_0FoVYhUeJUp01YBXyELLMkg at mail dot gmail dot com> <alpine dot DEB dot 2 dot 10 dot 1602101301131 dot 23420 at digraph dot polyomino dot org dot uk> <56BCB9C7 dot 6000100 at redhat dot com> <CAOKbPbZMt+ozv8dPbC8hpZr6yw2d2HcV4OskRP+Pk-i3oYu=nQ at mail dot gmail dot com> <56D5DFE3 dot 5010401 at redhat dot com> <CAOKbPbY_TPXBuFWT_eZCOBKiF-uSWZndAT3cuL3ZvZF+htbCRQ at mail dot gmail dot com> <CAOKbPbY0QW-KvhegDbs3NCuv-hHKyf-peuL1aBon+YTCt2SfEg at mail dot gmail dot com> <56E249E9 dot 4060404 at redhat dot com> <CAOKbPbYXgQyM8Gk-R4poMsdHz6eZ6=9ynq=hu=E8yrignf3N-w at mail dot gmail dot com> <56E6FF80 dot 3080202 at redhat dot com>
Hi again everyone,
Just wanted to report my status on this. I integrated the printer unit
tests to the NPTL Makefile, which means we can now run the tests by
doing 'make check'. I successfully tested the printers on a Beaglebone
Black using cross-test-ssh.sh as test-wrapper. If we're in a cross
build and don't specify a test-wrapper, it'll simply compile the test
programs but mark the tests themselves as UNRESOLVED.
I had to drop the 'GCC optimize' pragma because, at least on ARM, I
saw there were still a few optimizations being applied when compiling
with -O2 (at least the DWARF was different). I don't know if this is a
gcc bug; in any case I manage to work around this by setting the
CFLAGS-* variables for each test program in the Makefile.
I've also set the PExpect timeout to TIMEOUTFACTOR; if it's not
defined it'll default to 1 second.
I'm currently working on creating a separate subdirectory for the
pretty printers as Siddhesh said. I'll be placing both the printers
and their unit tests there, while the .pysym constants will remain in
the nptl subdir. If everything goes right I should be sending the
(hopefully final) patch in the following days.