This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 16/17 v5] x86, pthread_cond_*wait: Do not depend on %eax not being clobbered


On 14 Mar 2016, Florian Weimer said:

> On 03/13/2016 04:17 PM, Nix wrote:
>> From: Nick Alcock <nick.alcock@oracle.com>
>
>> 	* sysdeps/unix/sysv/linux/i386/pthread_cond_timedwait.S: Reload
>> 	call-clobbered %eax on retry path.
>> 	* sysdeps/unix/sysv/linux/i386/pthread_cond_wait.S: Likewise.
>
> Looks good.  Can you commit this yourself, or do you need someone to
> commit it for you?

I don't have commit rights, so if you or someone else wants to commit
it, commit away!

(and if anyone has any more comments on the rest of the patch, do fire
away with slings and arrows etc. I'd hope it's converging on something
acceptable after this many rounds... :) )

-- 
NULL && (void)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]