This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] glob: Avoid copying the d_name field of struct dirent [BZ #19779]
- From: Paul Eggert <eggert at cs dot ucla dot edu>
- To: Florian Weimer <fweimer at redhat dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Mar 2016 14:00:04 -0800
- Subject: Re: [PATCH] glob: Avoid copying the d_name field of struct dirent [BZ #19779]
- Authentication-results: sourceware.org; auth=none
- References: <56E339A7 dot 7060704 at redhat dot com>
I merely read the patch. Comments:
> +static void
> +convert_dirent (const struct dirent *source, struct abstract_dirent *target)
Since this is all inlined, how about if making it a pure function, with a
signature like this instead?
static struct abstract_dirent
convert_dirent (struct dirent const *source)
That should be a bit cleaner.
Otherwise, it looks good.