This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 11 Mar 2016 13:47:35 -0800 (PST)
- Subject: Re: [PATCH 1/2] Add _arch_/_cpu_ to index_*/bit_* in x86 cpu-features.h
- Authentication-results: sourceware.org; auth=none
- References: <1457049161-13783-1-git-send-email-hjl dot tools at gmail dot com> <CAMe9rOqmnA8TOOEo_KbxYnxaDDvzEcb+hqLHwK=dZ5J75W8d5Q at mail dot gmail dot com>
Your post didn't mention testing done. Every post of a patch you want
actually considered for approval should explicitly say what testing you
have done, and nobody should approve if you haven't clearly tested it.
Any patch that has been waiting for more than a day or two needs
explicit re-testing (and report of doing so) before you land it. This
change broke the 'make check' build on Linux/x86_64. There is really no
excuse for that.