This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 03/18] Do not stack-protect ifunc resolvers.


On 9 Mar 2016, Mike Frysinger outgrape:

> On 08 Mar 2016 13:50, Nix wrote:
>> +AC_CACHE_CHECK(if $CC accepts -fno-stack-protector with \
>> +__attribute__ ((__optimize__)),
>
> m4 strings should be quoted.  so this should be:
> AC_CACHE_CHECK([if $CC ........], ...

I copied it from the similarly unquoted

AC_CACHE_CHECK(if $CC accepts -fno-tree-loop-distribute-patterns with \
__attribute__ ((__optimize__)), libc_cv_cc_loop_to_function, [dnl
cat > conftest.c <<EOF

and didn't quote it out of unreasoning fear that \-escaping might get
broken if I did that.  I didn't actually *test* it, or I'd have seen that
my fears were groundless.  Fixed (at least, fixed my copy: I think the
other one is for another time).

-- 
NULL && (void)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]