This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Fwd: [PATCH] getnameinfo: Do not restore errno on error
- From: Zack Weinberg <zackw at panix dot com>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 8 Mar 2016 10:33:52 -0500
- Subject: Fwd: [PATCH] getnameinfo: Do not restore errno on error
- Authentication-results: sourceware.org; auth=none
- References: <56DEE16A dot 5010305 at redhat dot com> <CAKCAbMjp_gRyQqDPiDrj=P0xqSv_wqO7weBPWMCdJnrPh9xt-w at mail dot gmail dot com> <56DEEDCA dot 4030308 at redhat dot com> <CAKCAbMi4OdFL-t0zoLiuPy7Nqjaj9NvrbyBAB42t4kR84YiNCQ at mail dot gmail dot com>
unintentional off-list reply
---------- Forwarded message ----------
From: Zack Weinberg <zackw@panix.com>
Date: Tue, Mar 8, 2016 at 10:33 AM
Subject: Re: [PATCH] getnameinfo: Do not restore errno on error
To: Florian Weimer <fweimer@redhat.com>
On Tue, Mar 8, 2016 at 10:20 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 03/08/2016 04:14 PM, Zack Weinberg wrote:
>> On Tue, Mar 8, 2016 at 9:27 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>> POSIX does not require it, and this behavior is not documented
>>> in the manual page, either.
>>
>> This might be OK in the actual error case, but you're stomping on
>> errno in the *non*-error case too, which, even if allowed, should be
>> avoided as a matter of QoI.
>
> We currently do not have this as a general goal for glibc functions.
... well, maybe we *should*.
> I don't think getnameinfois special so that an exception is warranted (
> (unlike, say, free).
It's special in that it currently *does* preserve errno on success, so
taking that out is a step in the wrong direction.
zw