This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Copy x86_64 _mcount.op from _mcount.o
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Roland McGrath <roland at hack dot frob dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 4 Mar 2016 08:02:55 -0800
- Subject: Re: [PATCH] Copy x86_64 _mcount.op from _mcount.o
- Authentication-results: sourceware.org; auth=none
- References: <20160303134500 dot GA18701 at intel dot com> <20160304001016 dot 658F62C3B4D at topped-with-meat dot com> <CALoOobO+BO1GuZi7MB_L-mLSrMx8mpfDpAzJHtpgG2k1U=UGdA at mail dot gmail dot com> <20160304001930 dot 4ED112C3C0B at topped-with-meat dot com> <CAMe9rOr39A0tj5FgpC4Q-3a2EdTgbQorFdNzt6zq+ikZcG6qaA at mail dot gmail dot com>
On Fri, Mar 4, 2016 at 5:40 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Like this?
>
> --
> H.J.
> ---
> diff --git a/sysdeps/x86_64/Makefile b/sysdeps/x86_64/Makefile
> index 9fcadd8..788e4fc 100644
> --- a/sysdeps/x86_64/Makefile
> +++ b/sysdeps/x86_64/Makefile
> @@ -7,6 +7,9 @@ endif
>
> ifeq ($(subdir),gmon)
> sysdep_routines += _mcount
> +# We cannot compile _mcount.S with -pg because that would create
> +# recursive calls when ENTRY is used. Just copy the normal static
> +# object.
> sysdep_noprof += _mcount
> endif
Looks good to me.
Thanks,
--
Paul Pluzhnikov