This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "Carlos O'Donell" <carlos at redhat dot com>, Jonathan Wakely <jwakely at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 23 Feb 2016 16:32:48 +0100
- Subject: Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Authentication-results: sourceware.org; auth=none
- References: <20160201162152 dot GH3017 at tucnak dot redhat dot com> <20160201163400 dot GH3471 at redhat dot com> <56B23119 dot 3050605 at linaro dot org> <20160203174027 dot GK7732 at vapier dot lan> <56B2413D dot 1070309 at linaro dot org> <20160209172356 dot GC8441 at redhat dot com> <56BA240E dot 2080405 at redhat dot com> <56BA602E dot 5090009 at redhat dot com> <mvma8mrxxfl dot fsf at hawking dot suse dot de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Feb 23, 2016 at 04:23:42PM +0100, Andreas Schwab wrote:
> > +static int
> > +do_test (void)
> > +{
> > + /* Verify that isinff, isinfl, isnanf, and isnanlf are defined
> > + in the header under C++11 and can be called. Without the
> > + header fix this test will not compile. */
> > + if (isinff (1.0f)
> > + || !isinff (INFINITY)
> > + || isinfl (1.0L)
> > + || !isinfl (INFINITY)
> > + || isnanf (2.0f)
> > + || !isnanf (NAN)
> > + || isnanl (2.0L)
> > + || !isnanl (NAN))
>
> That doesn't compile on platforms where long == long double, since they
> do not declare any *l functions (arm, hppa, mips/o32).
>
> test-math-isinff.cc: In function 'int do_test()':
> test-math-isinff.cc:33:22: error: 'isinfl' was not declared in this scope
> || isinfl (1.0L)
> ^
> test-math-isinff.cc:37:22: error: 'isnanl' was not declared in this scope
> || isnanl (2.0L)
> ^
Thus the *l stuff needs to be guarded with
#ifndef __NO_LONG_DOUBLE_MATH
Jakub
- References:
- [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later
- Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later