This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Report dlsym, dlvsym lookup errors using dlerror [BZ #19509]
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Florian Weimer <fw at deneb dot enyo dot de>
- Cc: Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Wed, 10 Feb 2016 14:18:59 -0500
- Subject: Re: [PATCH] Report dlsym, dlvsym lookup errors using dlerror [BZ #19509]
- Authentication-results: sourceware.org; auth=none
- References: <56B9F83A dot 1000500 at redhat dot com> <56BA55C7 dot 6040505 at gmail dot com> <56BA5C0D dot 2040906 at redhat dot com> <87io1x342e dot fsf at mid dot deneb dot enyo dot de>
On 02/09/2016 05:35 PM, Florian Weimer wrote:
> * Carlos O'Donell:
>
>> A POSIX clarification should probably be made here, but I agree
>> that from a QoI it is better to return some kind of error because
>> that's users expect. I also expect that's what other implementations
>> do (but haven't verified).
>
> It's also what the Solaris examples suggest:
>
> <http://docs.oracle.com/cd/E19683-01/816-1386/chapter3-26/index.html>
>
> I don't see any reason why RTLD_NEXT should behave differently from
> other handles.
Agreed, and that's the *biggest* reason to fix this, namely that the
interfaces should behave the same (principle of least surprise).
I am reviewing your change.
I expect you are suggesting this change for 2.24 and not "right now"
for the upcoming release? I fear the change might change something
of consequence and I'd rather the checkin wait until Adhemerval cuts
the branch on the 18th.
Cheers,
Carlos.