Re: [PATCH] Preserve ::is{inf,nan}{f,l} prototypes even for C++11 and later

["Carlos O'Donell" <carlos at redhat dot com>]

On 02/09/2016 12:23 PM, Jonathan Wakely wrote:
> On 03/02/16 16:04 -0200, Adhemerval Zanella wrote:
>>
>>
>> On 03-02-2016 15:40, Mike Frysinger wrote:
>>> On 03 Feb 2016 14:55, Adhemerval Zanella wrote:
>>>> I will quote the email referenced:
>>>>
>>>>> C++11 code using isinf and isnan continues to compile after that
>>>>> change, because the C++11 standard library provides its own versions
>>>>> conforming to the C++11 requirements. However, the C++11 library
>>>>> doesn't provide isinff, isinfl etc. and so code using those
>>>>> (non-standard) functions will no longer compile if they are not
>>>>> declared by glibc.
>>>>
>>>> This was not clear to me, what kind of build issue are you seeing now?
>>>> Using isinf{f,l} by including just <cmath> along with C++11? If it is the
>>>> case please open a bugzilla (or update the original) and please commit
>>>> the fix.
>>>
>>> if the change hasn't seen a release yet, then we can just re-use the
>>> existing bug since it's really just a direct follow up to that ?
>>> -mike
>>>
>>
>> I do not see why not.
> 
> Hi, what's the status of this then - do we need to add a testcase or
> can it be committed for 2.23? (or wait for 2.24?)

Yes, we want always want a test case. It's perfectly fine to use C++
in  tests in glibc, and if the C++ compiler isn't present those tests
should become UNSUPPORTED tests, which is OK (when bootstrapping).

In summary:
- Add C++ test.
- Use BZ #19439 and provide ChangeLog.
- Post v2

I'll review it and commit, or someone else will.

Cheers,
Carlos.