This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] malloc: add locking to thread cache
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Joern Engel <joern at purestorage dot com>, "GNU C. Library" <libc-alpha at sourceware dot org>
- Cc: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>, <nd at arm dot com>
- Date: Tue, 26 Jan 2016 12:44:57 +0000
- Subject: Re: [PATCH] malloc: add locking to thread cache
- Authentication-results: sourceware.org; auth=none
- Nodisclaimer: True
- References: <1453767942-19369-1-git-send-email-joern at purestorage dot com> <1453767942-19369-52-git-send-email-joern at purestorage dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:23
On 26/01/16 00:25, Joern Engel wrote:
> With signals we can reenter the thread-cache. Protect against that with
> a lock. Will almost never happen in practice, it took the company five
> years to reproduce a similar race in the existing malloc. But easy to
> trigger with a targeted test.
why do you try to make malloc as-safe?
isn't it better to fix malloc usage in signal handlers?