This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix nptl/tst-setuid3.c
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: Florian Weimer <fweimer at redhat dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, "libc-alpha\ at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc:
- Date: Fri, 22 Jan 2016 16:31:04 -0200
- Subject: Re: [PATCH] Fix nptl/tst-setuid3.c
- Authentication-results: sourceware.org; auth=none
- References: <569E97E2 dot 1000307 at linux dot vnet dot ibm dot com> <569E99CF dot 3020504 at redhat dot com> <569E9AA0 dot 3070208 at linaro dot org> <569E9D4A dot 8050108 at linux dot vnet dot ibm dot com> <569E9DB4 dot 9080205 at redhat dot com> <569EC74C dot 7000301 at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> On 01/19/2016 02:33 PM, Florian Weimer wrote:
>> On 01/19/2016 09:32 PM, Paul E. Murphy wrote:
>>> +/* True if pthread_barrier_wait returns without an error. */
>>> +static inline bool
>>> +is_invalid_barrier_ret (int x)
>>> +{
>>> + return x != 0 && x != PTHREAD_BARRIER_SERIAL_THREAD;
>>> +}
>>
>> Sorry, just realized that the comment is wrong, should be âreturned
>> *with* an errorâ. :-/
>
> Thanks for point that out.
>
> Sigh, third time is a charm? I rewrote the comment.
Pushed as fad7e4d7 for 2.23.
--
Tulio Magno