This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Paul Pluzhnikov <ppluzhnikov at google dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>, Wei Mi <wmi at google dot com>
- Date: Wed, 20 Jan 2016 15:36:52 -0500
- Subject: Re: [patch] Use ENTRY/END in sysdeps/x86_64/nptl/pthread_spin*.S
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobPfYEt0R4LJo3cGZEP-JA5YFAT11sSSzLqsFamkXcdYNg at mail dot gmail dot com> <569D64D3 dot 7030400 at redhat dot com> <CALoOobPaEUbfOyA6-5ZmvrSdDGzbLcrKY-z6kksVHA-USUNHBg at mail dot gmail dot com> <CALoOobNiMZrxQ2WfpPDeLHRRsHO+URLx=eL_2Mv6k2Fg0aapPw at mail dot gmail dot com>
On 01/18/2016 06:44 PM, Paul Pluzhnikov wrote:
> On Mon, Jan 18, 2016 at 3:22 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
>> On Mon, Jan 18, 2016 at 2:18 PM, Carlos O'Donell <carlos@redhat.com> wrote:
>>
>>> It needs a public bug though.
>>
>> I opened https://sourceware.org/bugzilla/show_bug.cgi?id=19490
>
> Updated patch with fixed ChangeLog, pthread_cond_{broadcast,signal}
> and BZ entry added.
>
>
> 2016-01-18 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> [BZ #19490]
> * sysdeps/unix/sysv/linux/x86_64/pthread_cond_broadcast.S
> (pthread_cond_broadcast): Use ENTRY/END
> * sysdeps/unix/sysv/linux/x86_64/pthread_cond_signal.S
> (pthread_cond_signal): Likewise
> * sysdeps/x86_64/nptl/pthread_spin_lock.S (pthread_spin_lock):
> Likewise
> * sysdeps/x86_64/nptl/pthread_spin_trylock.S (pthread_spin_trylock):
> Likewise
> * sysdeps/x86_64/nptl/pthread_spin_unlock.S (pthread_spin_unlock):
> Likewise
Looks good to me.
Cheers,
Carlos.