This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix ppc macro usage of htm builtins
- From: Torvald Riegel <triegel at redhat dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Date: Wed, 20 Jan 2016 18:55:04 +0100
- Subject: Re: [PATCH] Fix ppc macro usage of htm builtins
- Authentication-results: sourceware.org; auth=none
- References: <569FB6CF dot 3070401 at linux dot vnet dot ibm dot com>
On Wed, 2016-01-20 at 10:33 -0600, Paul E. Murphy wrote:
> Some extraneous semicolons were included in a
> recent patch which causes a build failure with
> newer compilers.
>
> 2016-01-19 Paul E. Murphy <murphyp@linux.vnet.ibm.com>
>
> * sysdeps/unix/sysv/linux/powerpc/htm.h:
> (__libc_tbegin): Remove semicolon.
> (__libc_tend): Likewise.
> (__libc_tabort): Likewise.
> ---
> sysdeps/unix/sysv/linux/powerpc/htm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/powerpc/htm.h b/sysdeps/unix/sysv/linux/powerpc/htm.h
> index 16b2237..29cda8a 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/htm.h
> +++ b/sysdeps/unix/sysv/linux/powerpc/htm.h
> @@ -128,9 +128,9 @@
>
> # ifdef __TM_FENCE__
> /* New GCC behavior. */
> -# define __libc_tbegin(R) __builtin_tbegin (R);
> -# define __libc_tend(R) __builtin_tend (R);
> -# define __libc_tabort(R) __builtin_tabort (R);
> +# define __libc_tbegin(R) __builtin_tbegin (R)
> +# define __libc_tend(R) __builtin_tend (R)
> +# define __libc_tabort(R) __builtin_tabort (R)
> # else
> /* Workaround an old GCC behavior. Earlier releases of GCC 4.9 and 5.0,
> didn't use to treat __builtin_tbegin, __builtin_tend and
LGTM. We're in hard freeze, but I suppose such obvious fixes that
unbreak builds can go in?