This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 19 Jan 2016 23:04, Andreas Schwab wrote: > Mike Frysinger <vapier@gentoo.org> writes: > > --- a/test-skeleton.c > > +++ b/test-skeleton.c > > @@ -46,8 +46,9 @@ > > #endif > > > > #ifndef TIMEOUT > > - /* Default timeout is two seconds. */ > > -# define TIMEOUT 2 > > + /* Default timeout is twenty seconds. Tests should normally complete faster > > + than this, but if they don't, that's abnormal (a bug) anyways. */ > > +# define TIMEOUT 20 > > #endif > > You need to review all tests that override this value. in what way ? there are really only three states: - test doesn't set a timeout - a passing test doesn't care if you timeout in 2 sec or 1 year - a failing test would take longer to timeout now, but that test should already be logged, and i don't think this should affect the default to the detriment of the common case & valid systems - test sets a higher timeout - the custom timeout is still used - behavior is unchanged - test sets a lower timeout - the custom timeout is still used - behavior is unchanged now, if you mean "you should delete the #define TIMEOUT from all tests whose value is <=20", then yes, that's a cleanup that i'd probably do. but i wasn't going to bother updating >=50 files if we didn't want to accept the fundamental change i posted above. -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |