This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 07 Nov 2015 20:39, Martin Galvan wrote: > --- /dev/null > +++ b/nptl/nptl-printers.py > +import sys as the linter points out, this is unused, so you should drop it can you post a v4 with all the comments fixed ? > +MUTEX_TYPES = { > + PTHREAD_MUTEX_NORMAL: ('Type', 'Normal'), > + PTHREAD_MUTEX_RECURSIVE: ('Type', 'Recursive'), > + PTHREAD_MUTEX_ERRORCHECK: ('Type', 'Error check'), > + PTHREAD_MUTEX_ADAPTIVE_NP: ('Type', 'Adaptive') > +} imo, we should have dangling commas with lists/dicts/tuples like we do in C with arrays. -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |