This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Tunables for 2.23?
- From: Siddhesh Poyarekar <sid at reserved-bit dot com>
- To: Andi Kleen <andi at firstfloor dot org>
- Cc: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, "munroesj at linux dot vnet dot ibm dot com" <munroesj at linux dot vnet dot ibm dot com>, Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>
- Date: Fri, 8 Jan 2016 11:15:18 +0530
- Subject: Re: Tunables for 2.23?
- Authentication-results: sourceware.org; auth=none
- References: <568C2AE6 dot 90002 at linux dot vnet dot ibm dot com> <20160108022037 dot GC4698 at two dot firstfloor dot org>
On Fri, Jan 08, 2016 at 03:20:37AM +0100, Andi Kleen wrote:
> diff --git a/tunables/tunables.c b/tunables/tunables.c
> index 6e5aaa9..e8a5690 100644
> --- a/tunables/tunables.c
> +++ b/tunables/tunables.c
> @@ -182,7 +182,7 @@ tunable_register (tunable_id_t id, tunable_setter_t set_func, char **envp)
> tunable_t *cur = &tunable_list[id];
>
> cur->set = set_func;
> - if (cur->val != NULL)
> + if (cur->val != NULL && *cur->val)
> {
> set_func (cur->val);
> cur->initialized = true;
>
>
Thanks, someone (Dmitry Levine, or was it Aureliene Jarno?) had
pointed this out to me at the Cauldron last year and I had fixed it in
my local copy. I'll push my updated patches today, which should have
this change.
Siddhesh