This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Khem Raj <raj dot khem at gmail dot com>, <libc-alpha at sourceware dot org>
- Date: Mon, 4 Jan 2016 15:36:41 +0000
- Subject: Re: [PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC
- Authentication-results: sourceware.org; auth=none
- References: <1451679626-28351-1-git-send-email-raj dot khem at gmail dot com> <568A1AEE dot 4050402 at redhat dot com>
On Mon, 4 Jan 2016, Florian Weimer wrote:
> On 01/01/2016 09:20 PM, Khem Raj wrote:
>
> > +#ifdef _LIBC
> > __fxprintf (fs->stream, "%.*s", (int) (fs->p - fs->buf), fs->buf);
> > +#else
> > + fwrite_unlocked (fs->buf, 1, fs->p - fs->buf, fs->stream);
> > +#endif
>
> Why not use fwrite_unlocked unconditionally?
Does fwrite_unlocked work on wide-oriented streams in glibc (the point of
__fxprintf as I understand it being to work whatever the orientation of
the stream)?
--
Joseph S. Myers
joseph@codesourcery.com