This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Avoid redundant shift character in iconv output at block boundary (bug 17197)
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Martin Sebor <msebor at gmail dot com>, libc-alpha at sourceware dot org
- Date: Tue, 15 Dec 2015 10:50:17 +0100
- Subject: Re: [PATCH] Avoid redundant shift character in iconv output at block boundary (bug 17197)
- Authentication-results: sourceware.org; auth=none
- References: <mvm7fo1pbwy dot fsf at hawking dot suse dot de> <5668C219 dot 8070606 at gmail dot com> <mvmsi3abtbl dot fsf at hawking dot suse dot de> <5669C008 dot 7050902 at gmail dot com> <mvmr3ipa03u dot fsf at hawking dot suse dot de> <566EECEE dot 5050705 at gmail dot com> <566F0224 dot 7020004 at redhat dot com> <mvm7fkg9j7s dot fsf at hawking dot suse dot de>
On 12/15/2015 10:03 AM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
>
>> Andreas, looking at the other direction (specifically, the first loop in
>> ibm930.c), it seems that an SI character while already in multi-byte
>> mode is illegal. Does this mean the current encoder produces an illegal
>> output sequence?
>
> Yes, that looks like.
Okay, not good, but I don't think it's worth to add a compatibility mode
for this.
I think this is ready to commit (if you are satisfied with Martin's and
my review).
Florian