This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ#19347] grantpt: trust the kernel about pty group and permission mode
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: libc-alpha at sourceware dot org, Jakub Wilk <jwilk at debian dot org>, Florian Weimer <fw at deneb dot enyo dot de>, Adam Conrad <adconrad at 0c3 dot net>
- Date: Thu, 10 Dec 2015 18:56:04 +0100
- Subject: Re: [PATCH v2] [BZ#19347] grantpt: trust the kernel about pty group and permission mode
- Authentication-results: sourceware.org; auth=none
- References: <1449617673-23034-1-git-send-email-aurelien at aurel32 dot net> <mvmzixi9v7d dot fsf at hawking dot suse dot de>
On 2015-12-10 16:31, Andreas Schwab wrote:
> > +2015-12-06 Aurelien Jarno <aurelien@aurel32.net>
> > + Jakub Wilk <jwilk@debian.org>
> > +
> > + [BZ #19347]
> > + * sysdeps/unix/grantpt.c (grantpt): Do not try to change the group
> > + of the device to the tty group when built without pt_chown support.
>
> Ok, but please use "[!HAVE_PT_CHOWN]" instead of "when built without
> pt_chown support".
Thanks for the review, I'll commit it with this change.
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net