This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] malloc: remove redundant getenv call


On 11/24/2015 05:26 PM, Gleb Fotengauer-Malinovskiy wrote:

> +              const char *str_buffer_size;
> +

The currently preferred style is to minimize the declarative region,
that is, declare the variable as late as possible (and usually
initialize it instead of assigning it).

This change also needs a ChangeLog entry.

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]