Re: [PATCH] [BZ #19178] Add a test for prelink output

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Tue, Nov 10, 2015 at 1:43 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Tue, 10 Nov 2015, H.J. Lu wrote:
>
>> On Mon, Nov 9, 2015 at 6:42 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> > On Sat, Nov 7, 2015 at 7:54 AM, Szabolcs Nagy <nsz@port70.net> wrote:
>> >> * H.J. Lu <hongjiu.lu@intel.com> [2015-11-07 06:55:02 -0800]:
>> >>> This test applies to i386 and x86_64 which set R_386_GLOB_DAT and
>> >>> R_X86_64_GLOB_DAT to ELF_RTYPE_CLASS_EXTERN_PROTECTED_DATA.  OK for
>> >>> master?
>> >>>
>> >>
>> >> why is the test x86 specific?
>> >>
>> >> extern protected data handling and LD_TRACE_PRELINKING
>> >> seem to be generic.
>> >
>> > It only applies to GLOB_DAT relocation.  Not all targets have it
>> > and I have only x86 to test.
>> >
>>
>> I will check it in and backport the fix with this this to 2.22 branch.
>
> I see no sign of consensus for an x86-specific test here.  I too think the
> test should be written in an architecture-independent way, with a way for
> architectures for which it is inapplicable to disable it.

Here is a patch to run it on targets with GLOB_DAT reloc.


-- 
H.J.

Attachment: git.txt
Description: Text document