This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] Fixed family and model detection for AMD CPU's


On Thu, 5 Nov 2015, Pawar, Amit wrote:

> Hi Florian,
> 
> This is a correctness patch where family and model detection was wrong.

That doesn't answer the question.  What do you mean by "wrong"?  What is 
the background documentation that shows that the proposed change makes the 
logic correct?

A proper explanation might be along the lines of "processor X reports 
values A, B, C from CPUID; the existing code follows paths P and Q that 
wrongly identify it as processor Y, but, as explained in document R (URL), 
CPUID values on AMD processors should be interpreted as way S, meaning 
that the logic should change in way T".  And with a bug filed in Bugzilla 
if this was user-visible (e.g. inappropriate function implementations 
being selected in glibc because of the wrong choices).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]