This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't macro-expand failed assertion expression
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: David Kastrup <dak at gnu dot org>, <libc-alpha at sourceware dot org>
- Date: Tue, 3 Nov 2015 22:44:25 +0000
- Subject: Re: [PATCH] Don't macro-expand failed assertion expression
- Authentication-results: sourceware.org; auth=none
- References: <1446541374-2063-1-git-send-email-dak at gnu dot org> <563934AB dot 7090402 at redhat dot com>
On Tue, 3 Nov 2015, Florian Weimer wrote:
> On 11/03/2015 10:02 AM, David Kastrup wrote:
> > [BZ #18604]
> > * assert/assert.h (assert): Don't macro-expand failed assertion
> > expression in error message.
> >
> > * malloc/malloc.c (assert): Likewise.
>
> Thanks, committed and pushed. (I'm assuming you don't have access to
> sourceware.)
You need to update the list of fixed bugs in NEWS when committing a fix
for a bug, since automatic generation of that list is not yet in use.
And you need to set the milestone when marking a bug as fixed, so that
when automatic generation is in use it gets included in the generated list
of fixed bugs. (I think there was consensus on the principle of automatic
generation, even in the absence of any comments on the concrete
implementation I proposed in
<https://sourceware.org/ml/libc-alpha/2015-10/msg01043.html>.)
--
Joseph S. Myers
joseph@codesourcery.com