This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 2/5] Clean pthread functions namespaces for C11 threads
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Thu, 29 Oct 2015 21:08:40 +0000
- Subject: Re: [PATCH v2 2/5] Clean pthread functions namespaces for C11 threads
- Authentication-results: sourceware.org; auth=none
- References: <1440515272-9453-1-git-send-email-j dot m dot torrespalma at gmail dot com> <1440515272-9453-3-git-send-email-j dot m dot torrespalma at gmail dot com>
I'm happy with this patch except for the calls to
PTHREAD_STATIC_FN_REQUIRE (__pthread_create_2_1) in source files not
defining pthread_create. I think the knowledge that __pthread_create_2_1
is the name of the main pthread_create implementation is something that
should be local to the source file defining pthread_create. My
preference, for this patch and for the call to __pthread_create_2_1 in
patch 3, would be for a preliminary patch to rename __pthread_create_2_1
to __pthread_create.
--
Joseph S. Myers
joseph@codesourcery.com