This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Gracefully handle incompatible locale data
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Samuel Thibault <samuel dot thibault at gnu dot org>, Ludovic CourtÃs <ludo at gnu dot org>
- Cc: libc-alpha at sourceware dot org, guix-devel at gnu dot org
- Date: Wed, 28 Oct 2015 02:19:33 -0400
- Subject: Re: [PATCH] Gracefully handle incompatible locale data
- Authentication-results: sourceware.org; auth=none
- References: <876132lbic dot fsf at gnu dot org> <20151027153037 dot GB2483 at var dot bordeaux dot inria dot fr>
On 10/27/2015 11:30 AM, Samuel Thibault wrote:
> Hello,
>
> Ludovic Courtès, le Tue 22 Sep 2015 17:27:55 +0200, a écrit :
>> loadlocale.c:130: _nl_intern_locale_data: Assertion `cnt < (sizeof (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))' failed.
>>
>> This patch changes such conditions to return EINVAL instead of aborting.
>
> Just like it does for the __glibc_unlikely (idx > (size_t)
> newdata->filesize) test above, so it doesn't actually introduce any new
> error condition.
>
> I thus commited the change, thanks!
>
> Samuel
>
Thanks Samuel!
c.