This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv5] - powerpc: Add hwcap/hwcap2/platform data to TCB.
- From: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
- To: Andreas Schwab <schwab at linux-m68k dot org>
- Cc: Peter Bergner <bergner at vnet dot ibm dot com>, Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>, GNU C Library <libc-alpha at sourceware dot org>, "Carlos O'Donell" <carlos at redhat dot com>, Tulio Machado <tuliom at linux dot vnet dot ibm dot com>, "Steven J. Munroe" <sjmunroe at us dot ibm dot com>
- Date: Mon, 26 Oct 2015 16:51:09 -0500
- Subject: Re: [PATCHv5] - powerpc: Add hwcap/hwcap2/platform data to TCB.
- Authentication-results: sourceware.org; auth=none
- References: <462274D6-C7A4-4186-8B73-65BE70336DE6 at linux dot vnet dot ibm dot com> <1445880936 dot 30998 dot 34 dot camel at vnet dot ibm dot com> <1445890065 dot 11373 dot 18 dot camel at oc7878010663> <87oaflb9td dot fsf at igel dot home>
- Reply-to: munroesj at linux dot vnet dot ibm dot com
On Mon, 2015-10-26 at 22:26 +0100, Andreas Schwab wrote:
> Steven Munroe <munroesj@linux.vnet.ibm.com> writes:
>
> > Are you sure current an future versions of GCC will handle this
> > promotion to 64-bit correctly across the shift and or operation?
>
> What do you mean? The expression has a well-defined meaning. There is
> no room for interpretation.
>
The current patch is correct as is, so this just a matter of taste.
I find types of variables easier to follow than internal casts.
And it seems like GLIBC had a bug recently specific to shifting 32-bit
values.
But I will let Carlos decide what he wants to do.