This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- From: Florian Weimer <fweimer at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>, Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 26 Oct 2015 13:36:21 +0100
- Subject: Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- Authentication-results: sourceware.org; auth=none
- References: <560471F5 dot 9080800 at gmail dot com> <mvmh9lwzaxk dot fsf at hawking dot suse dot de> <561B92D6 dot 4010402 at redhat dot com> <20151012164344 dot GB4446 at vapier dot lan>
On 10/12/2015 06:43 PM, Mike Frysinger wrote:
> so it creates one dep per locale. the rule for processing these targets:
> $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES)): %: \
> ../localedata/gen-locale.sh \
> $(common-objpfx)locale/localedef \
> ../localedata/Makefile \
> $(addprefix ../localedata/charmaps/,$(CHARMAPS)) \
> $(addprefix ../localedata/locales/,$(LOCALE_SRCS))
> @$(SHELL) ../localedata/gen-locale.sh $(common-objpfx) \
> '$(built-program-cmd-before-env)' '$(run-program-env)' \
> '$(built-program-cmd-after-env)' $@; \
> $(evaluate-test)
>
> so it generates one locale per invocation. it looks correct to me.
>
> then again, it's fairly easy to test: just go into one of these dirs,
> delete the locale output, and run `make -j`. see if any of the commands
> are repeated.
I still see occasional crashes in the localedata tests. Your âmake -jâ
check does not work because the action in the rule above is prefixed
with â@â. Can we remove that, so that we may end up with more evidence
of unsynchronized, parallel execution?
Florian