This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] S390: Clean setjmp, longjmp, getcontext symbols.


ping

On 10/13/2015 09:35 AM, Stefan Liebler wrote:
Hi,

for each function setjmp, longjmp, getcontext, there exist a symbol
<func> and a default/versioned symbol <func>@@GLIBC_2.x in the build
obj-files.
This is wrong because it should only exist an unversioned or a
default-versioned symbol with the same name in an obj-file.
Glibc can't be build with recent binutils. See the already fixed linker
bug https://sourceware.org/bugzilla/show_bug.cgi?id=19073.
Nevertheless, this patch cleans this up.

Furthermore the BSD entry points setjmp, _setjmp were marked as weak,
but should be strong as on other architectures.
(see https://sourceware.org/ml/libc-alpha/2014-07/msg00568.html for an
older discussion with Andreas Schwab)

Some whitespace issues are corrected in sysdeps/s390/s390-64/setjmp.S,
too. But there is no change in the assembler code.

Bye Stefan

---
2015-10-13  Stefan Liebler  <stli@linux.vnet.ibm.com>

     * sysdeps/s390/longjmp.c (longjmp, _longjmp, siglongjmp):
     Don't create weak aliases,
     because versioned symbols are created later.
     * sysdeps/s390/s390-32/setjmp.S
     (setjmp, _setjmp): Remove weak and rename to an unique name
     in SHARED case due to existing versioned symbols.
     * sysdeps/s390/s390-64/setjmp.S: Likewise.
     * sysdeps/unix/sysv/linux/s390/s390-32/getcontext.S
     (getcontext): Create weak alias only in non SHARED case.
     * sysdeps/unix/sysv/linux/s390/s390-64/getcontext.S: Likewise.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]