This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/3] Mark ld.so internel mmap functions hidden
- From: Richard Henderson <rth at twiddle dot net>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Roland McGrath <roland at hack dot frob dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 19 Oct 2015 10:45:07 -1000
- Subject: Re: [PATCH 1/3] Mark ld.so internel mmap functions hidden
- Authentication-results: sourceware.org; auth=none
- References: <1445189141-18068-1-git-send-email-hjl dot tools at gmail dot com> <20151019183113 dot 29D732C3AA0 at topped-with-meat dot com> <CAMe9rOo0cs_bDbKo1+-+ObeyDd09SUrPaYpCR7ACq0x0-f-usw at mail dot gmail dot com>
On 10/19/2015 09:31 AM, H.J. Lu wrote:
+# if IS_IN (rtld)
+# include <dl-mman.h>
+extern __typeof (__mprotect) __mprotect attribute_hidden;
+extern __typeof (__munmap) __munmap attribute_hidden;
Surely if mmap can't be hidden, then munmap can't either.
Surely you should just put all of these within dl-mman.h, even if in the end
there are a few lines of overlap.
r~