This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- From: Andreas Schwab <schwab at suse dot de>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Martin Sebor <msebor at gmail dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 17 Oct 2015 09:41:38 +0200
- Subject: Re: [PATCH] 18969 - multiple string test failures due to missing locale dependencies
- Authentication-results: sourceware.org; auth=none
- References: <560471F5 dot 9080800 at gmail dot com> <mvmh9lwzaxk dot fsf at hawking dot suse dot de> <561B92D6 dot 4010402 at redhat dot com> <20151012164344 dot GB4446 at vapier dot lan> <mvmziznxmsi dot fsf at hawking dot suse dot de> <20151017031601 dot GF28215 at vapier dot lan>
Mike Frysinger <vapier@gentoo.org> writes:
> On 13 Oct 2015 09:14, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>> > pretty sure that's not a problem. $(gen-locales) expands into:
>> > CTYPE_FILES = $(addsuffix /LC_CTYPE,$(LOCALES))
>> > gen-locales := $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES))
>> >
>> > so it creates one dep per locale.
>>
>> Each subdir has its independent set of dependencies.
>>
>> > $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES)): %: \
>> > ../localedata/gen-locale.sh \
>> > $(common-objpfx)locale/localedef \
>> > ../localedata/Makefile \
>> > $(addprefix ../localedata/charmaps/,$(CHARMAPS)) \
>> > $(addprefix ../localedata/locales/,$(LOCALE_SRCS))
>> > @$(SHELL) ../localedata/gen-locale.sh $(common-objpfx) \
>> > '$(built-program-cmd-before-env)' '$(run-program-env)' \
>> > '$(built-program-cmd-after-env)' $@; \
>> > $(evaluate-test)
>> >
>> > so it generates one locale per invocation. it looks correct to me.
>>
>> Different subdirs can build the same locale in parallel.
>
> to be clear, i didn't say otherwise, and i'm aware of this behavior.
> i was pointing out that each subdir builds each required locale in
> parallel and does so with proper targets.
That has no influence on the global behaviour.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."