This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Assume that SOCK_CLOEXEC is available and works
- From: Florian Weimer <fw at deneb dot enyo dot de>
- To: GNU C Library <libc-alpha at sourceware dot org>
- Date: Sat, 17 Oct 2015 07:39:57 +0200
- Subject: Re: [PATCH] Assume that SOCK_CLOEXEC is available and works
- Authentication-results: sourceware.org; auth=none
- References: <561CF8CC dot 3030608 at redhat dot com> <20151017032510 dot GG28215 at vapier dot lan>
* Mike Frysinger:
> On 13 Oct 2015 14:27, Florian Weimer wrote:
>> This fixes (harmless, I assume) data races when accessing the various
>> __have_sock_cloexec variables.
>>
>> Compiled and tested on x86_64-redhat-linux-gnu. According to the
>> previous thread (âO_CLOEXEC and SOCK_CLOEXECâ), there might be some
>> impact of this change on Hurd and NaCl, but it seems manageable.
>
> looks good, but shouldn't we also drop __ASSUME_O_CLOEXEC ?
Thanks. Yes, __ASSUME_O_CLOEXEC is next, but it seemed it would be a
much larger patch, so I wanted to test the waters first.