This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- From: Steven Munroe <munroesj at linux dot vnet dot ibm dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>
- Cc: Carlos Eduardo Seo <cseo at linux dot vnet dot ibm dot com>, Peter Bergner <bergner at vnet dot ibm dot com>, Roland McGrath <roland at hack dot frob dot com>, Joseph Myers <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Tulio Machado <tuliom at linux dot vnet dot ibm dot com>, "Steven J. Munroe" <sjmunroe at us dot ibm dot com>
- Date: Mon, 12 Oct 2015 10:31:35 -0500
- Subject: Re: [PATCHv3] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB
- Authentication-results: sourceware.org; auth=none
- References: <4BE991CB-F601-4D63-A416-5991FE870FC4 at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232114070 dot 10585 at digraph dot polyomino dot org dot uk> <B650304C-6207-46AC-B6A8-FA29959B305D at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 10 dot 1509232141250 dot 10585 at digraph dot polyomino dot org dot uk> <1443046986 dot 23503 dot 68 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232234500 dot 10585 at digraph dot polyomino dot org dot uk> <1443050731 dot 23503 dot 78 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509232340470 dot 10585 at digraph dot polyomino dot org dot uk> <1443057751 dot 13186 dot 6 dot camel at otta> <alpine dot DEB dot 2 dot 10 dot 1509240126140 dot 10585 at digraph dot polyomino dot org dot uk> <1443058522 dot 13186 dot 9 dot camel at otta> <1443654009 dot 4885 dot 4 dot camel at oc7878010663> <B2EB15A6-FEB5-4DBA-8719-0BAA5B65EF5E at linux dot vnet dot ibm dot com> <5615CD5D dot 1080409 at redhat dot com> <3C6704AA-1037-487A-BE68-BFACCB6A15C4 at linux dot vnet dot ibm dot com> <56182013 dot 9060106 at redhat dot com>
- Reply-to: munroesj at linux dot vnet dot ibm dot com
On Fri, 2015-10-09 at 16:14 -0400, Carlos O'Donell wrote:
> On 10/07/2015 11:03 PM, Carlos Eduardo Seo wrote:
> >
> > Thanks for the review. Answers below:
>
> Thank you again for you patience in the review process.
>
> >> On Oct 7, 2015, at 10:56 PM, Carlos O'Donell <carlos@redhat.com> wrote:
> >>
> >> (a) Reference to GLIBC_2.23 in ppc.h functions?
> >
> > A dummy call should be harmless at that point. What do you think? If
> > you have a better idea, please let me know.
>
> You don't need this if, as Steven and Peter suggest, you initialize
> everything before CTORs are run.
>
> Therefore you should be cutting this code and verifying your hooks
> run before CTORs.
>
So where do we document the dependency so some does not come along in
the furture and break things?