This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] Remove ancient GCC string inlines
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Fri, 9 Oct 2015 16:01:05 +0000
- Subject: Re: [PATCH 2/2] Remove ancient GCC string inlines
- Authentication-results: sourceware.org; auth=none
- References: <000401d102aa$8db859e0$a9290da0$ at com>
On Fri, 9 Oct 2015, Wilco Dijkstra wrote:
> Move mempcpy, strcpy and stpcpy inlines to string/string-inlines.c as
> they are no longer used in string2.h. Passes AArch64, x86 and x64
> regression.
I take it's that's full testsuite runs, not just the string/ directory
(so, in particular, you verified that the ABI tests for libc.so pass and
that these functions are still in libc.so for x86 - I don't see quite how
that would work with this patch since you didn't touch
sysdeps/i386/string-inlines.c).
As a followup, such functions (no longer used in inlines in any installed
header) could be made into compat symbols (not in libc.a, not available
for new links, not included in future glibc ports).
--
Joseph S. Myers
joseph@codesourcery.com