This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64 and s390
- From: Paul Pluzhnikov <ppluzhnikov at google dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Wed, 7 Oct 2015 22:19:04 -0700
- Subject: Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64 and s390
- Authentication-results: sourceware.org; auth=none
- References: <CALoOobN6U4bEXMB3UdW7=6OuH0mJW+iA7+xE8+AiZtVGg3knAw at mail dot gmail dot com> <5614CEDB dot 5040709 at redhat dot com> <CALoOobMEvHOLK2LQ+UtKch2PZ52anx7=QS9QNC9sZU1iDCD-NA at mail dot gmail dot com> <CALoOobMH9RNcUe913EtBnCKuEN=-OoQXYr27VctH2qPdmvYCLQ at mail dot gmail dot com> <CALoOobOCxqzsG7H5_M4Cc6gCPzRGH-aDs7F_avYy=gvgZ47pqw at mail dot gmail dot com> <CALoOobMEO3sxuxZWtcou-=Dz14RJq-=yPE66ORAqPMzhBT9shw at mail dot gmail dot com> <5615FBE7 dot 2080602 at redhat dot com>
On Wed, Oct 7, 2015 at 10:15 PM, Florian Weimer <fweimer@redhat.com> wrote:
>> And again with space-before-paren.
>
> One space still missing (although the space rule does not apply to (all)
> macros, only to function calls, so it's slightly unclear what's correct
> for attributes).
Other examples have more spaces, e.g.
__attribute__ ((section (".text.fma4")))
so I'll add the other missing space.
> Can you say in the commit message that this is to work around breakage
> on aarch64?
Sure. Ok to commit then?
Thanks,
--
Paul Pluzhnikov