This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix build error for tst-printf-bz18872 on arm/aarch64 and s390


On Wed, Oct 7, 2015 at 10:15 PM, Florian Weimer <fweimer@redhat.com> wrote:

>> And again with space-before-paren.
>
> One space still missing (although the space rule does not apply to (all)
> macros, only to function calls, so it's slightly unclear what's correct
> for attributes).

Other examples have more spaces, e.g.

__attribute__ ((section (".text.fma4")))

so I'll add the other missing space.

> Can you say in the commit message that this is to work around breakage
> on aarch64?

Sure. Ok to commit then?

Thanks,
-- 
Paul Pluzhnikov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]