This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Use LOAD_PIC_REG in i386 atanh [committed]
- From: Joseph Myers <joseph at codesourcery dot com>
- To: <libc-alpha at sourceware dot org>
- Date: Thu, 24 Sep 2015 21:49:06 +0000
- Subject: Use LOAD_PIC_REG in i386 atanh [committed]
- Authentication-results: sourceware.org; auth=none
sysdeps/i386/fpu/e_atanh.S, unlike all other functions in that
directory, loads the PIC register with its own code using
_GLOBAL_OFFSET_TABLE_, rather than with the LOAD_PIC_REG macro. I see
no good reason for the difference; this patch makes it use the common
macro.
Tested for x86. Committed.
2015-09-24 Joseph Myers <joseph@codesourcery.com>
* sysdeps/i386/fpu/e_atanh.S (__ieee754_atanh) [PIC]: Use
LOAD_PIC_REG.
diff --git a/sysdeps/i386/fpu/e_atanh.S b/sysdeps/i386/fpu/e_atanh.S
index 5772bbf..448c76b 100644
--- a/sysdeps/i386/fpu/e_atanh.S
+++ b/sysdeps/i386/fpu/e_atanh.S
@@ -55,11 +55,7 @@ ENTRY(__ieee754_atanh)
7:
#ifdef PIC
- call 1f
- cfi_adjust_cfa_offset (4)
-1: popl %edx
- cfi_adjust_cfa_offset (-4)
- addl $_GLOBAL_OFFSET_TABLE_+[.-1b], %edx
+ LOAD_PIC_REG (dx)
#endif
andl $0x80000000, %ecx // ECX == 0 iff X >= 0
--
Joseph S. Myers
joseph@codesourcery.com