Re: [PATCH v4] timezone: add a configure flag to disable program install

[ricaljasan <ricaljasan at pacific dot net>]

Probably late on this, being a casual digestor of libc-alpha, but here
are my two cents:

On 09/18/2015 02:49 PM, Mike Frysinger wrote:
> Some distros build+install the timezone tools (zic/zdump/tzselect) outside
> of glibc and use the upstream package directly.  Add a configure flag to
> glibc so they can disable install of those tools.
> 
> This allows tests to run & pass regardless of the configure flag.  Only
> the install of them is impacted.

I know it's acceptably colloquial, but: s/install/&ation/


> diff --git a/INSTALL b/INSTALL

> +'--disable-timezone-tools'
> +     By default, timezone related utilities ('zic', 'zdump', and

I would write "timezone-related".

> +     'tzselect') are installed with glibc.  If you are building these
> +     independently (e.g.  by using the 'tzcode' package), then this

Put a comma after "e.g.", as it's a prepositional phrase.  Also, there
are two spaces after the period, where there should only be one.

> +     option will allow disabling the install of these too.

s/install/&ation/ (suggested)

Drop the "too".  In the context of this option's description, nothing
else has yet been referenced as having its installation disabled.

Actually, I would probably rewrite the then-clause like, "...will
disable their installation."

> +     Note that you need to make sure the external tools are kept in sync
> +     with the versions that the GNU C Library expects as the data
> +     formats may change over time.  Consult the 'timezone' subdirectory
> +     for more details.

I would drop "that" after "versions".

s/expects/&,/


> diff --git a/configure b/configure

> +  --disable-timezone-tools
> +                          do not install timezone tools (if using external
> +                          ones) [default=install]

I don't think the parenthetical statement is necessary, and is a little
misleading.  The option's behaviour does not depend on the use of
external timezone tools (i.e., it doesn't check whether external tools
are used).  Not that the statement isn't correct or helpful, but it can
be read both ways, so I'd prefer less ambiguity.  Just saying the
timezone tools won't be installed is both sufficient and reassuring in
its definitiveness.


> diff --git a/configure.ac b/configure.ac

> +			     [do not install timezone tools (if using external ones) @<:@default=install@:>@]),

Likewise.


> diff --git a/manual/install.texi b/manual/install.texi

> +By default, timezone related utilities (@command{zic}, @command{zdump},

"timezone-related" (suggested)

> +and @command{tzselect}) are installed with glibc.  If you are building

@theglibc{}

> +these independently (e.g. by using the @samp{tzcode} package), then this

Comma after "e.g.".

> +option will allow disabling the install of these too.

s/install/&ation/ (suggested)

Drop "too".

(alt: "...will disable their installation.")

> +Note that you need to make sure the external tools are kept in sync with
> +the versions that @theglibc{} expects as the data formats may change over

Drop "that" after "versions". (suggested)

s/expects/&,/


Rical Jasan