This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [COMMITTED] Fix GCC6 build errors due to unused statics
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Wilco Dijkstra <wdijkstr at arm dot com>
- Cc: 'GNU C Library' <libc-alpha at sourceware dot org>
- Date: Fri, 18 Sep 2015 22:07:41 +0000
- Subject: RE: [COMMITTED] Fix GCC6 build errors due to unused statics
- Authentication-results: sourceware.org; auth=none
- References: <002501d0f24b$8fc25110$af46f330$ at com> <alpine dot DEB dot 2 dot 10 dot 1509181953470 dot 23145 at digraph dot polyomino dot org dot uk> <002601d0f24d$13032080$39096180$ at com> <alpine dot DEB dot 2 dot 10 dot 1509182004040 dot 23145 at digraph dot polyomino dot org dot uk> <002701d0f256$461365d0$d23a3170$ at com>
On Fri, 18 Sep 2015, Wilco Dijkstra wrote:
> 2015-09-18 Wilco Dijkstra <wdijkstr@arm.com>
>
> * timezone/Makefile: Ignore unused variable errors due to private.h
> (time_t_min) and (time_t_max).
I've reverted this timezone/Makefile change since it broke the build for
all released versions of GCC, which is more important than the build with
GCC 6 (where we have several months before a release to work out what
warnings should be there at all).
Please recalibrate your notion of obviousness so you are much more wary of
committing patches that haven't been reviewed. See the list of obvious
types of changes at <https://sourceware.org/glibc/wiki/Consensus>.
Someone indicating a general direction without having seen a patch is
*not* approval for some arbitrary future patch following that direction,
unless they specifically say e.g. "OK with that change".
--
Joseph S. Myers
joseph@codesourcery.com