This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ #18433] Check file access/existence before forking.


On Thu, 2015-09-10 at 19:35 +0430, Navid Rahimi wrote:
> I think our main objection here is to avoid forking when there is no 
> file.There is so many other variable for checking if execve is going to 
> success or not.

On the other hand, your patch will add an extra system call and
directory lookup to every successful posix_spawn() call, i.e. you are
optimising the failure case at the expense of the successful case.  It's
not at all obvious to me that this is a sensible thing to do.  Can you
explain your reasoning in a bit more detail?

p.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]