Re: Don't use -Wno-error=undef

[Mike Frysinger <vapier at gentoo dot org>]

On 18 Aug 2015 17:27, Joseph Myers wrote:
> On Tue, 18 Aug 2015, Mike Frysinger wrote:
> > On 18 Aug 2015 16:21, Joseph Myers wrote:
> > > This patch, relative to a tree with
> > > <https://sourceware.org/ml/libc-alpha/2015-08/msg00680.html> and
> > > <https://sourceware.org/ml/libc-alpha/2015-08/msg00681.html> (pending
> > > review) applied, removes the use of -Wno-error=undef, so that -Wundef
> > > warnings become errors.
> > 
> > lgtm
> 
> Are you saying those patches look good as well as the -Wno-error=undef 
> removal?

sure, both lgtm too

> > > Tested for x86_64 and x86.  If people see build or test errors
> > > resulting from this on other architectures, they should fix those as
> > > usual.
> > 
> > is it possible to compile all the tests (and not run them) ?
> > i can do a few quick sanity checks for some arches ...
> 
> "make check" should do that by default when building with a cross compiler 
> (it will also do tests that only require the build system and not the host 
> glibc runs on, such as the ABI tests).

hmm, it seems to try to execute for me.  probably because cross_compiling=maybe
rather than yes or no.
-mike

Attachment: signature.asc
Description: Digital signature