This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Define HAS_CPUID/HAS_I586/HAS_I686 from -march=


On Mon, Aug 17, 2015 at 10:24 PM, OndÅej BÃlka <neleai@seznam.cz> wrote:
> On Mon, Aug 17, 2015 at 04:10:05PM -0700, H.J. Lu wrote:
>> cpuid, i586 and i686 instructions are available if the processor
>> specified by -march= supports them.  We can use this information
>> to determine whether those instructions can be used safely.
>>
>> OK for master?
>>
> Patch itself looks ok. It fixes theoretical problem that if there would
> be new processor without cpuid it would cause problem.
>
> But could you explain rationale? Here you replaced one like with
> equivalent longer macro and HAS_I586 is never used. Do you plan followup
> patches that use that?

I will use HAS_I586 and HAS_I686 in multi-arch for i486 and i586
I am working on.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]