This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [2.23 PATCH] Desupport regexp.h (bug 18681)
- From: Zack Weinberg <zackw at panix dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 17 Aug 2015 11:28:46 -0400
- Subject: Re: [2.23 PATCH] Desupport regexp.h (bug 18681)
- Authentication-results: sourceware.org; auth=none
- References: <20150805152109 dot 2FDA114B9A at panix1 dot panix dot com> <mqs78o$a16$1 at ger dot gmane dot org> <55D1E207 dot 30203 at panix dot com> <20150817135629 dot GE1584 at vapier> <CAKCAbMhzyp8gTcn073+a7R7Hgz3t=ntYKouWH-AfhWPr8OnQqQ at mail dot gmail dot com> <mvm8u9aezn8 dot fsf at hawking dot suse dot de> <CAKCAbMhw=fF1w5z7nCKurVMcX+g2DJcFETaJ66tTFsLB=gs0iQ at mail dot gmail dot com>
On Mon, Aug 17, 2015 at 11:08 AM, Zack Weinberg <zackw@panix.com> wrote:
> Just now I did this again and also ran `git clean -dxf` in the source
> tree (which deleted only editor backups) and -- this is a little weird
> -- it compiles without complaint, but the VERSION_libc_GLIBC_2_xx
> #defines in abi-versions.h only go up to 2_22.
I take that back. I *am* getting the same warning as Stefan, it just
didn't cause a build failure and scrolled off the top of my terminal.
The misc/Versions change suggested by Mike does cure the problem, so
here is a properly formatted patch.
zw
* misc/Versions: Add empty GLIBC_2.23 stanza, to prevent
undefined macro warnings in regexp.c.
---
misc/Versions | 3 +++
1 file changed, 3 insertions(+)
diff --git a/misc/Versions b/misc/Versions
index 534d1a3..671f487 100644
--- a/misc/Versions
+++ b/misc/Versions
@@ -149,6 +149,9 @@ libc {
GLIBC_2.16 {
__getauxval; getauxval;
}
+ GLIBC_2.23 {
+ # SHLIB_COMPAT(GLIBC_2_0, GLIBC_2_23) used in regexp.c
+ }
GLIBC_PRIVATE {
__madvise;
__mktemp;
--
2.5.0