This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC] Add IFUNC support for MIPS (v3)
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Faraz Shahbazker <faraz dot shahbazker at imgtec dot com>
- Cc: "libc-alpha\ at sourceware dot org" <libc-alpha at sourceware dot org>, <rdsandiford at googlemail dot com>, Joseph Myers <joseph at codesourcery dot com>
- Date: Fri, 14 Aug 2015 22:57:35 +0200
- Subject: Re: [RFC] Add IFUNC support for MIPS (v3)
- Authentication-results: sourceware.org; auth=none
- References: <DCB1C42372B1674B8F912A294CCB775A71684631 at BADAG02 dot ba dot imgtec dot org> <87k2tdn5xt dot fsf at googlemail dot com> <55BFC10F dot 2050503 at imgtec dot com> <87k2tapwq0 dot fsf at googlemail dot com> <55CE5217 dot 5020902 at imgtec dot com>
Faraz Shahbazker <faraz.shahbazker@imgtec.com> writes:
> + if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_SYMBOLS, 0))
__builtin_expect -> __glibc_unlikely
> + if (__builtin_expect (r_type == R_MIPS_IRELATIVE, 1))
__builtin_expect -> __glibc_likely
> + if (__glibc_likely(ref != NULL)) \
Space before paren.
> + if (__glibc_likely(map->l_info[DT_MIPS (GENERAL_GOTNO)] != NULL))
Space before paren.
> + if (sym != NULL
> + && __builtin_expect (ELFW(ST_TYPE) (sym->st_info)
> + == STT_GNU_IFUNC, 0))
__builtin_expect -> __glibc_unlikely and indentation.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."