This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] i386: Assembly Implementation cleanup


On Wed, 12 Aug 2015, Florian Weimer wrote:

> I would suggest to define a new macro (say,
> __usues_many_argument_syscall or something shorter) which expands to
> "__attribute__ ((optimize ("omit-frame-pointer), noinline))” on i386 and
> apply it to the function in the C source file, instead of adding it to
> the makefiles (assuming that this works, I have not tried it).  This
> way, it would be more explicit what happens.  In the documentation of
> the new macro, quote a typical GCC error message if a many-argument
> system call is used without it.

I see several uses of the affected lowlevellock-futex.h macros that aren't 
in the files listed in that Makefile change - are they all in files with 
separate x86-specific versions?

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]