This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/5] Add C11 threads.h support.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Juan Manuel Torres Palma <j dot m dot torrespalma at gmail dot com>
- Cc: <libc-alpha at sourceware dot org>, Juan Manuel Torres Palma <jmtorrespalma at gmail dot com>
- Date: Mon, 10 Aug 2015 14:56:17 +0000
- Subject: Re: [PATCH 3/5] Add C11 threads.h support.
- Authentication-results: sourceware.org; auth=none
- References: <1439217470-23427-1-git-send-email-j dot m dot torrespalma at gmail dot com> <1439217470-23427-4-git-send-email-j dot m dot torrespalma at gmail dot com>
On Mon, 10 Aug 2015, Juan Manuel Torres Palma wrote:
> * sysdeps/unix/sysv/linux/powerpc/powerpc32/libpthread.abilist:
> Likewise.
> * sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread.abilist:
> Likewise.
Missing sysdeps/unix/sysv/linux/powerpc/powerpc64/libpthread-le.abilist,
which also needs updating.
> -linknamespace-libs-isoc = $(common-objpfx)libc.a $(common-objpfx)math/libm.a
> +linknamespace-libs-isoc = $(common-objpfx)libc.a $(common-objpfx)math/libm.a \
> + $(common-objpfx)nptl/libpthread.a
No, libpthread.a should only be considered in linknamespace testing for
ISO11, not for ISO or ISO99.
> diff --git a/include/stdc-predef.h b/include/stdc-predef.h
> index e5f1139..1a5d899 100644
> --- a/include/stdc-predef.h
> +++ b/include/stdc-predef.h
> @@ -58,7 +58,5 @@
> published. */
> #define __STDC_ISO_10646__ 201304L
>
> -/* We do not support C11 <threads.h>. */
> -#define __STDC_NO_THREADS__ 1
>
Should also remove a blank line here instead of leaving two before #endif.
> diff --git a/nptl/Versions b/nptl/Versions
> index 34e4b46..93ae190 100644
> --- a/nptl/Versions
> +++ b/nptl/Versions
> @@ -266,8 +266,20 @@ libpthread {
> GLIBC_2.20 {
> }
>
> - GLIBC_2.22 {
> - }
Are you sure it's safe to remove this empty GLIBC_2.22 section (present
for the use of SHLIB_COMPAT calls, see nptl/pt-fork.c and commit
beff1d132c16aedd87a3f1bc7b572c8e69819015)?
--
Joseph S. Myers
joseph@codesourcery.com