This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH][BZ #17250] Static dlopen default library search path fix

From: Mike Frysinger <vapier at gentoo dot org>
To: "Maciej W. Rozycki" <macro at linux-mips dot org>
Cc: Andreas Schwab <schwab at suse dot de>, Roland McGrath <roland at hack dot frob dot com>, OndÅej BÃlka <neleai at seznam dot cz>, Allan McRae <allan at archlinux dot org>, libc-alpha at sourceware dot org
Date: Thu, 6 Aug 2015 02:06:57 -0400
Subject: Re: [PATCH][BZ #17250] Static dlopen default library search path fix
Authentication-results: sourceware.org; auth=none
References: <alpine dot DEB dot 1 dot 10 dot 1310252347350 dot 12843 at tp dot orcam dot me dot uk> <20140116203847 dot GB20838 at domone dot podge> <alpine dot DEB dot 1 dot 10 dot 1401172303320 dot 4268 at tp dot orcam dot me dot uk> <20140117233957 dot 64E307441B at topped-with-meat dot com> <alpine dot DEB dot 1 dot 10 dot 1401271320170 dot 4268 at tp dot orcam dot me dot uk> <alpine dot DEB dot 1 dot 10 dot 1401291054290 dot 4268 at tp dot orcam dot me dot uk> <mvmfv3zxkhk dot fsf at hawking dot suse dot de> <alpine dot LFD dot 2 dot 20 dot 1508041538290 dot 1410 at eddie dot linux-mips dot org> <mvmvbcvvz1b dot fsf at hawking dot suse dot de> <alpine dot LFD dot 2 dot 20 dot 1508041948170 dot 1410 at eddie dot linux-mips dot org>

On 04 Aug 2015 21:52, Maciej W. Rozycki wrote:
> On Tue, 4 Aug 2015, Andreas Schwab wrote:
> > >  What problem are you seeing or trying to solve?
> > 
> > https://sourceware.org/bugzilla/show_bug.cgi?id=17250
> 
>  Umm, thanks.  Having looked through the patch again it looks to me like I 
> got confused with the negative `__builtin_expect' expression.  My change 
> was not neutral as intended as it's where DF_1_NODEFLIB is *set* that the 
> conditional executes.

we cc-ed you on it originally ... do you not see bugzilla e-mails ?
i'm just wondering how to address the visibility aspect.

>  I'm not prepared to properly regression-test a change right away, but 
> meanwhile can you try the below as a proposed fix?  Also I'm not sure 
> offhand how to make a test case that covers this issue, but I'll be happy 
> to accept ideas and implement them.

two were posted to the bug.  if you use tests-static in the Makefile,
should be fairly easy to add to the tree and check the result.
-mike

Attachment: signature.asc
Description: Digital signature

Follow-Ups:
- Re: [PATCH][BZ #17250] Static dlopen default library search path fix
  - From: Maciej W. Rozycki

References:
- Re: [PATCH][BZ #16046] Static dlopen correction fallout fixes
  - From: Andreas Schwab
- Re: [PATCH][BZ #16046] Static dlopen correction fallout fixes
  - From: Maciej W. Rozycki
- Re: [PATCH][BZ #16046] Static dlopen correction fallout fixes
  - From: Andreas Schwab
- [PATCH][BZ #17250] Static dlopen default library search path fix
  - From: Maciej W. Rozycki

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]