Re: [PATCH] Kill regexp.h

[Zack Weinberg <zackw at panix dot com>]

On 07/15/2015 12:01 AM, Mike Frysinger wrote:
> On 12 Jul 2015 15:27, Zack Weinberg wrote:
>> Therefore, this patch stubs out the header and demotes the
>> implementation to compatibility symbols.
> 
> our current workflow says that all user visible changes (like this) require a 
> bugzilla bug to be created for reference.  please do that and update the various
> pieces with that BZ #.

OK, filed https://sourceware.org/bugzilla/show_bug.cgi?id=18681 .

>> +#if SHLIB_COMPAT(libc, GLIBC_2_0, GLIBC_2_22)
> 
> should be a space before the (

Thanks, I haven't coded to the GNU style standards in a long time.

>> -/* Define the variables used for the interface.  */
>>  char *loc1;
>>  char *loc2;
>> -
>> -/* Although we do not support the use we define this variable as well.  */
>>  char *locs;
> 
> should probably leave the comments alone

yeah, ok

>> +#error "GNU libc no longer implements <regexp.h>."
>> +#error "Revise your code to use <regex.h> (no P)."
> 
> how about changing the parenthetical aside to:
>  ... (no trailing 'p').

ok

Attachment: signature.asc
Description: OpenPGP digital signature