This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v5] Add and use new glibc-internal futex API.


> I've removed the changes to nptl/cancellation.c from this patch because
> I was running into build failures on i686-linux, which happen when calls
> to __libc_fatal() or abort() exist in the code.  This seems to happen
> when IS_IN (libc) is true.  I don't know why that happens but it seems
> orthogonal to the futex API.  Therefore, to move forward with the futex
> API, I choose to simply drop the respective changes from the patch.

The problem was in the rtld incarnation of that file.  It wasn't possible
to use __libc_fatal in rtld.  I've just committed a change to fix that.
So please put the cancellation.c change back in.

Note that this wasn't for i686-linux-gnu, in particular.  It was for
everything except x86_64-linux-gnu, which has its own cancellation.S.
That file should disappear with the big cancellation revamp anyway.


Thanks,
Roland


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]